Skip to content

Conversation

navaneedan07
Copy link

pull request

Closes #2982


Reviewer Resources:

Track Policies

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @navaneedan07, @jagdish-15 has commented in #2982 to create a forum post for this one. Assuming the streams concept is added, we should also add a concept exercise to give students the chance to practice using it.

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navaneedan07, did you want to have a go at coming up with a concept exercise for streams? Concepts are generally accompanied by a concept exercise to allow students to practice.

See Implement a Concept Exercise for details or have a look at captain's log for an example. You're also welcome to post questions here 😉

@@ -0,0 +1,6 @@
{
"blurb": "Java Streams provide a powerful way to process collections using a functional approach.",
"authors": ["Navaneedan S"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Exercism to award you reputation points, this should be your Github username navaneedan07.

@@ -0,0 +1,21 @@
# About Streams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The about is missing the information contained in the introduction (e.g. being able to get a stream with List.stream(), examples of how to get and use streams, etc.).

The about.md instead of the introduction.md is shown after the student finishes the concept. It should contain at least the same information from the introduction.md, although it can go into greater detail (see File: about.md for a greater description).

I also recommend looking at existing concepts and their introduction.md and about.md to get a feel of it.

List<String> filtered = names.stream()
.filter(name -> name.startsWith("A"))
.collect(Collectors.toList());
// filtered is ["Akash"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if this is still a work in progress - the closing triple backticks are missing 😅. If not, I think it would be great to have examples for map and reduce since they are also mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(concepts): add Streams concept
3 participants